Implement RadioGroup::{row,column,for_axis} to allow layout customization#2157
Merged
jneem merged 3 commits intolinebender:masterfrom Mar 28, 2022
twitchyliquid64:master
Merged
Implement RadioGroup::{row,column,for_axis} to allow layout customization#2157jneem merged 3 commits intolinebender:masterfrom twitchyliquid64:master
jneem merged 3 commits intolinebender:masterfrom
twitchyliquid64:master
Conversation
jneem
reviewed
Mar 26, 2022
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'd be inclined to copy the Flex naming for consistency, even if it is a breaking change. (e.g. RadioGroup::column, RadioGroup::row, and RadioGroup::for_axis) What do you think about that?
Contributor
Author
|
Sure thing! I'll get on it this weekend :) |
twitchyliquid64
changed the title
Contributor
Author
|
Done! please take a look :) |
Member
|
Looks great, thanks! We'll definitely want a changelog entry too (which I can do today if you don't have time). (Note that the links in the changelog aren't automatic; they're all defined at the bottom) |
Contributor
Author
|
Done, thanks! |
jneem
approved these changes
Mar 27, 2022
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Thanks for your patience! I have to wait for CI to finish, and then I'll merge.
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial change to allow the user to set the Axis on which Radio's are laid out. Breaking change in that
RadioGroup::newis nowRadioGroup::column.Builder methods
column(),row(),for_axis()are consistent with theFlexwidget.