-
Notifications
You must be signed in to change notification settings - Fork 569
Introducing intrinsics #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Introducing intrinsics #2172
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4066f23
* Introducing `IntrinsicWidth` widget.
sjoshid 9e906fd
Merge branch 'master' of https://github.com/linebender/druid into Int…
sjoshid b823f7a
* Removing sj_todo
sjoshid 0aaecaf
* PR suggestions
sjoshid 0f3e326
* Refactoring as per jneem suggestions.
sjoshid 0704914
* Warn max intrinsic height of label is unimplemented.
sjoshid 487eca4
* Refactoring only.
sjoshid ff87274
* Refactoring only.
sjoshid bbef0db
* Changelog only.
sjoshid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| use druid::Data; | ||
sjoshid marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| use crate::widget::Axis; | ||
| use crate::{ | ||
| BoxConstraints, Env, Event, EventCtx, LayoutCtx, LifeCycle, LifeCycleCtx, PaintCtx, Size, | ||
| UpdateCtx, Widget, | ||
| }; | ||
|
|
||
| /// A widget that sizes its child to the child's maximum intrinsic width. | ||
| /// | ||
| /// This widget is useful, for example, when unlimited width is available and you would like a child | ||
| /// that would otherwise attempt to expand infinitely to instead size itself to a more reasonable | ||
| /// width. | ||
| /// | ||
| /// The constraints that this widget passes to its child will adhere to the parent's | ||
| /// constraints, so if the constraints are not large enough to satisfy the child's maximum intrinsic | ||
| /// width, then the child will get less width than it otherwise would. Likewise, if the minimum | ||
| /// width constraint is larger than the child's maximum intrinsic width, the child will be given | ||
| /// more width than it otherwise would. | ||
| pub struct IntrinsicWidth<T> { | ||
| child: Box<dyn Widget<T>>, | ||
| } | ||
|
|
||
| impl<T: Data> IntrinsicWidth<T> { | ||
| /// Wrap the given `child` in this widget. | ||
| pub fn new(child: impl Widget<T> + 'static) -> Self { | ||
| Self { | ||
| child: Box::new(child), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl<T: Data> Widget<T> for IntrinsicWidth<T> { | ||
| fn event(&mut self, ctx: &mut EventCtx, event: &Event, data: &mut T, env: &Env) { | ||
| self.child.event(ctx, event, data, env); | ||
| } | ||
|
|
||
| fn lifecycle(&mut self, ctx: &mut LifeCycleCtx, event: &LifeCycle, data: &T, env: &Env) { | ||
| self.child.lifecycle(ctx, event, data, env); | ||
| } | ||
|
|
||
| fn update(&mut self, ctx: &mut UpdateCtx, old_data: &T, data: &T, env: &Env) { | ||
| self.child.update(ctx, old_data, data, env); | ||
| } | ||
|
|
||
| fn layout(&mut self, ctx: &mut LayoutCtx, bc: &BoxConstraints, data: &T, env: &Env) -> Size { | ||
| let iw = self | ||
| .child | ||
| .compute_max_intrinsic(Axis::Horizontal, ctx, bc, data, env); | ||
| let new_bc = bc.shrink_max_width_to(iw); | ||
|
|
||
| self.child.layout(ctx, &new_bc, data, env) | ||
| } | ||
|
|
||
| fn paint(&mut self, ctx: &mut PaintCtx, data: &T, env: &Env) { | ||
| self.child.paint(ctx, data, env); | ||
| } | ||
|
|
||
| fn compute_max_intrinsic( | ||
| &mut self, | ||
| axis: Axis, | ||
| ctx: &mut LayoutCtx, | ||
| bc: &BoxConstraints, | ||
| data: &T, | ||
| env: &Env, | ||
| ) -> f64 { | ||
| match axis { | ||
| Axis::Horizontal => self.child.compute_max_intrinsic(axis, ctx, bc, data, env), | ||
| Axis::Vertical => { | ||
| if !bc.is_width_bounded() { | ||
| let w = self | ||
| .child | ||
| .compute_max_intrinsic(Axis::Horizontal, ctx, bc, data, env); | ||
| let new_bc = bc.shrink_max_width_to(w); | ||
| self.child | ||
| .compute_max_intrinsic(axis, ctx, &new_bc, data, env) | ||
| } else { | ||
| self.child.compute_max_intrinsic(axis, ctx, bc, data, env) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.