Change into_span! to trace_span! to reduce noise#2203
Merged
cmyr merged 2 commits intolinebender:masterfrom Jul 8, 2022
Merged
Change into_span! to trace_span! to reduce noise#2203cmyr merged 2 commits intolinebender:masterfrom
cmyr merged 2 commits intolinebender:masterfrom
Conversation
NickLarsenNZ
force-pushed
the
tracing-level
branch
from
21c4895 to
6df1180
Compare
Contributor
Author
|
@cmyr I have followed the instructions from |
cmyr
approved these changes
Jul 5, 2022
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Cool, thanks, I agree that trace is probably a more appropriate level here.
Something we should consider is a convenience method on the AppLauncher that lets the user specify the log level; currently we always set the level to Debug.
Member
|
@NickLarsenNZ can you rebase this when you get a chance? |
Contributor
Author
Done :) |
Member
|
@NickLarsenNZ did you maybe forget to push? |
Contributor
Author
|
Oh, sorry. I tried using the GitHub button to update. I'll sort that out soon. |
NickLarsenNZ
force-pushed
the
tracing-level
branch
from
6df1180 to
c415f2f
Compare
Contributor
Author
|
@cmyr I've rebased to the latest |
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
* change into_span! to trace_span! to reduce noise linebender#2202 * add to changelog and authors list
xarvic
pushed a commit
to xarvic/druid
that referenced
this pull request
Jul 29, 2022
* change into_span! to trace_span! to reduce noise linebender#2202 * add to changelog and authors list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2202