Skip to content

Add ZStack widget#2235

Merged
xarvic merged 12 commits intolinebender:masterfrom
xarvic:z-stack
Aug 18, 2022
Merged

Add ZStack widget#2235
xarvic merged 12 commits intolinebender:masterfrom
xarvic:z-stack

Conversation

@xarvic
Copy link
Collaborator

@xarvic xarvic commented Jul 28, 2022

Adds a ZStack widget which stacks widgets on top of each other and handles the hot state of overlapping widgets correctly.
Adds the obstructed flag to MouseEvent which is used by WidgetPod to determine if the widget should be hot.

@jneem
Copy link
Member

jneem commented Aug 2, 2022

I think it definitely makes sense to have a z-stack widget; it seems like a basic building block. I'm unsure about the "obstructed" business, though. Is the set_handled mechanism not good enough?

@xarvic xarvic requested review from cmyr and xStrom August 3, 2022 13:07
@xarvic xarvic removed request for cmyr and xStrom August 3, 2022 14:04
@xarvic
Copy link
Collaborator Author

xarvic commented Aug 3, 2022

I'm unsure about the "obstructed" business, though. Is the set_handled mechanism not good enough?

I changed the implementation. This makes is_handled a bit more complex, but overall i think it is a better design.

Copy link
Member

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response...

@xarvic
Copy link
Collaborator Author

xarvic commented Aug 18, 2022

Thanks :)

@xarvic xarvic merged commit ffcbc49 into linebender:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants