Replace lazy_static with once_cell#2263
Replace lazy_static with once_cell#2263cmyr merged 1 commit intolinebender:masterfrom jplatte:once-cell
Conversation
notgull
left a comment
notgull
left a comment
There was a problem hiding this comment.
The only real issue I have with this is the inclusion of version 1.15.0 of OnceCell, which includes a dramatic MSRV bump to rustc 1.56. I'm not sure what the MSRV policy is for Druid, but if it's lower than 1.56 this could introduce an unnecessary bump.
This can be avoided by using ^1.14 instead.
|
I haven't seen an MSRV specified anywhere. Happy to reduce the minimum version of once_cell if maintainers prefer. |
|
Druid is experimental, so I have no problem advancing the MSRV. I'm happy to see stuff move forward. |
|
So can this be merged then? :) |
|
Rebased, and lowered the minimum version for |
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Sure let's try this, and we'll see if anything breaks 💁
4 participants
lazy_staticis increasingly getting replaced byonce_celland it's nice not to have multiple dependencies for the same thing.