Skip to content

Bump piet.#2290

Merged
jneem merged 3 commits intomasterfrom
bump-piet
Nov 25, 2022
Merged

Bump piet.#2290
jneem merged 3 commits intomasterfrom
bump-piet

Conversation

@jneem
Copy link
Member

@jneem jneem commented Nov 25, 2022

This also required bumping cairo and therefore gtk.

This also required bumping cairo and therefore gtk.
@jneem
Copy link
Member Author

jneem commented Nov 25, 2022

PS: I tried fixing the beta lints, but ran into trouble. There's a new manual_clamp lint that over-aggressive (in my opinion) because clamp panics with max < min, and we have a couple of places where max < min is allowed. Allowing clippy::manual_clamp breaks the non-beta build because there's a lint against unknown lints. We could turn off that lint, but I think it's actually useful...

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cmyr
Copy link
Member

cmyr commented Nov 25, 2022

And fair on the lints, we can figure it out when they creep into stable. :)

@jneem jneem merged commit dd496ab into master Nov 25, 2022
@cmyr cmyr deleted the bump-piet branch November 26, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants