Skip to content

Fix meta not being a modifier.#2293

Merged
jneem merged 1 commit intolinebender:masterfrom
lzhoucs:meta-fix
Nov 28, 2022
Merged

Fix meta not being a modifier.#2293
jneem merged 1 commit intolinebender:masterfrom
lzhoucs:meta-fix

Conversation

@lzhoucs
Copy link
Contributor

@lzhoucs lzhoucs commented Nov 27, 2022

We added super -> meta for GTK in #331, however we didn't convert the modifier state. This has left inconsistency for super key events from GTK which is converted to a regular meta key by us. This causes issues in lapce when super key is used as a modifier key, e.g: when adding a key binding for save by pressing super + s, only s is captured as shown below:
before this fix - press super + s:
image
after this fix - press super + s:
image

We can also see the issue in the example app event_viewer:
before this fix - press ctrl key:
image

before this fix - press super key:
image

after this fix - press super key:
image

@jneem jneem added the 0.8 label Nov 27, 2022
@xStrom xStrom added shell/gtk concerns the GTK backend S-needs-review waits for review labels Nov 27, 2022
@jneem
Copy link
Member

jneem commented Nov 28, 2022

Thanks, looks good!

@jneem jneem merged commit d1ffcde into linebender:master Nov 28, 2022
@xStrom xStrom removed the S-needs-review waits for review label Nov 28, 2022
@lzhoucs lzhoucs deleted the meta-fix branch December 12, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

port-to-glazier shell/gtk concerns the GTK backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants