Add a public constructor to StringCursor#2319
Merged
xStrom merged 3 commits intolinebender:masterfrom Jan 11, 2023
Merged
Conversation
StringCursor fields being private is the only thing preventing a user to define its own EditableText, unless it directly wraps an existing one.
xStrom
reviewed
Jan 10, 2023
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Looks reasonable, just need a slight change to the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringCursorfields being private is the only thing preventing a user to define its ownEditableText, unless it directly wraps an existing one.As an exemple, with this patch it is possible to wrap a
RichText, implement few traits, and use it in aTextBox.