Add Event::WindowScale and Ctx::scale for easier scale handling.#2335
Merged
xStrom merged 5 commits intolinebender:masterfrom Jan 16, 2023
Merged
Add Event::WindowScale and Ctx::scale for easier scale handling.#2335xStrom merged 5 commits intolinebender:masterfrom
Event::WindowScale and Ctx::scale for easier scale handling.#2335xStrom merged 5 commits intolinebender:masterfrom
Conversation
xStrom
added
widget
jneem
approved these changes
Jan 16, 2023
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Whoever wrote svg originally didn't like imports 😄
Contributor
|
@jneem no i didn't. =) |
Contributor
|
@xStrom all looks good to me. =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event::WindowScalewasn't fully connected, but thedruid-shellpart of it is somewhat functional, although not complete. Still, it's better to move this forward and surface the event to widgets.The
Ctx::scalemethod is added to every context and makes accessing the current window's scale as easy as accessing the widget's size. This is really a convenience method to improve ergonomics and doesn't enable new functionality.Additionally I cleaned up the new SVG widget (from #2106) and it now makes use of this scale information to properly render the SVG at various scale factors.
Fixes #2333