Remove set_layout_rect and fix deprecation declarations.#2340
Merged
xStrom merged 2 commits intolinebender:masterfrom Jan 22, 2023
Merged
Remove set_layout_rect and fix deprecation declarations.#2340xStrom merged 2 commits intolinebender:masterfrom
set_layout_rect and fix deprecation declarations.#2340xStrom merged 2 commits intolinebender:masterfrom
Conversation
jneem
approved these changes
Jan 22, 2023
jaredoconnell
approved these changes
Jan 22, 2023
xStrom
added a commit
to xStrom/druid
that referenced
this pull request
Jan 22, 2023
xStrom
added a commit
to xStrom/druid
that referenced
this pull request
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WidgetPod::set_layout_recthas been soft-deprecated since #1289. Then #2149 changed its signature. I considered changing its signature back to the previous one and giving it a proper deprecation declaration. However looking at the code, it doesn't even set the widget's layout rect. So at this point the method has outlived its usefulness and should be removed.use_simple_loggerdeprecation declaration was incorrectly claiming version 0.7, so I changed it to 0.8.The
Parsewidget was deprecated way back in #1377 and even declared so in the changelog. However the struct never got a proper declaration. Better late than never.