Fix ScrollComponent not handling LifeCycle::HotChanged.#2343
Merged
xStrom merged 2 commits intolinebender:masterfrom Jan 26, 2023
Merged
Fix ScrollComponent not handling LifeCycle::HotChanged.#2343xStrom merged 2 commits intolinebender:masterfrom
ScrollComponent not handling LifeCycle::HotChanged.#2343xStrom merged 2 commits intolinebender:masterfrom
Conversation
xStrom
added
widget
jaredoconnell
approved these changes
Jan 24, 2023
Contributor
jaredoconnell
left a comment
jaredoconnell
left a comment
There was a problem hiding this comment.
Looks good to me. I just confirmed that the scroll bar gets stuck for the old versions, but not for your patch.
jneem
approved these changes
Jan 26, 2023
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Didn't test it personally, but it looks fine.
longmathemagician
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
LifeCycle::HotChangedhandling toScrollComponentwhich allows it to hide the scroll bars when the widget loses hot state but doesn't receive anyMouseMoveevents that would confirm this. This bug was hidden on GTK thanks to #552 but revealed again due to #2324.The fix can be seen in action with the
scroll_colorsexample as seen below: