Merged
Conversation
longmathemagician
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piet v0.6.1 comes with lots of documentation fixes, which is good for us because we embed it in the Druid docs.
Interestingly this revealed a bad actor in our dependency graph. The
resvgcrate pinspngto=0.17.6. The way cargo works, this means that no other crate that Druid uses, or even any project that uses Druid can use any other semver compatiblepngversion.Thus I think the solution here is to revert back to
resvgv0.25 which is just a few months older, but has a much sanerpngdependency of^0.17. This issue has been brought to the attention ofresvgin resvg#571 where they confirm their intention to change this in the future. For now I don't think we should propagate that pin to all projects depending on Druid. No bug fixes topng(e.g. v0.17.8) would reach apps usingdruidthat way.