Foreground function for Container Widget and WidgetExt

[giannissc]

No description provided.

[jaredoconnell]

I left a comment about a test failure.

There are also some formatting problems that need to be fixed. There is some valuable information here: https://github.com/linebender/druid/blob/master/CONTRIBUTING.md

Lastly, don't forget to add your PR to the changelog. You can also add yourself to the authors file.

[xStrom]

Generally looks fine, but I've got some inline comments.

Also, when you're done with the changes don't forget to run cargo fmt.

[xStrom]

I guess BackgroundBrush is no longer a great name. Not a change we need to worry about in this PR though.

[giannissc]

Yeah I was thinking the same since I was preparing the PR. Since this didn't make it in time should I prepare another PR for the BackgroundBrush change?

[xStrom]

If you wish, sure. After we merge this one here.

[giannissc]

Should I just rename it to Brush? I am also thinking PrimitivesBrush

[xStrom]

Brush sort-of clashes with Piet's Brush so perhaps not. Given that it is defined in painter.rs I'm also thinking maybe PaintBrush. Although we could maybe go with something non-brush even, given that it supports a full Painter widget as a variant. 🤔

[xStrom]

Please add a CHANGELOG.md entry for these changes. You probably need to rebase on master first to avoid merge conflicts.

The main entry in the unreleased version's added section at the top of the file:

### Added

- `foreground`, `set_foreground`, and `clear_foreground` methods to `Container` and `WidgetExt::foreground` method for convenience. ([#2346] by [@giannissc])

Then also define your profile link and the PR link at the very bottom of the file.

[@giannissc]: https://github.com/giannissc

[...]

[#2346]: https://github.com/linebender/druid/pull/2346

[giannissc]

Ready to be merged! @xStrom

[xStrom]

Thanks!