Add info about symbolic links to CONTRIBUTING.md.#2349
Merged
xStrom merged 3 commits intolinebender:masterfrom Feb 9, 2023
Merged
Add info about symbolic links to CONTRIBUTING.md.#2349xStrom merged 3 commits intolinebender:masterfrom
CONTRIBUTING.md.#2349xStrom merged 3 commits intolinebender:masterfrom
Conversation
jaredoconnell
approved these changes
Jan 29, 2023
jneem
approved these changes
Feb 9, 2023
Member
jneem
left a comment
jneem
left a comment
There was a problem hiding this comment.
Sorry, didn't realize @jaredoconnell didn't have write access...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured out what was happening with v0.8.0 getting a bad
README.mdon crates.io. Turns out thatgiton Windows by default disables symbolic link support. I have now manually enabled it and tested with a test crate that publishing symlinks works as expected.In this PR I delete the temporary copy of
README.mdand re-introduce the symlink. I also added a new section toCONTRIBUTING.mdto help prevent this issue in the future.