Skip to content

Synchronize kurbo and image imports with piet-common.#2352

Merged
xStrom merged 5 commits intolinebender:masterfrom
xStrom:sync-kurbo-and-image
Jan 30, 2023
Merged

Synchronize kurbo and image imports with piet-common.#2352
xStrom merged 5 commits intolinebender:masterfrom
xStrom:sync-kurbo-and-image

Conversation

@xStrom
Copy link
Member

@xStrom xStrom commented Jan 30, 2023

Druid v0.8 ended up shipping with a different major version of image than Piet, which causes severe issues due to their incompatibility, as pointed out by @jpochyla. The ultimate solution to this is to import the image and kurbo crates from piet-common so that they remain synchronized.

@xStrom xStrom added maintenance cleans up code or docs S-needs-review waits for review labels Jan 30, 2023
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, once the build issues are fixed. Most importantly it looks less error prone. Assuming this doesn't mess up the way to use those crates externally.

Copy link
Contributor

@longmathemagician longmathemagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xStrom xStrom removed the S-needs-review waits for review label Jan 30, 2023
@xStrom xStrom merged commit c8ce0b6 into linebender:master Jan 30, 2023
@xStrom xStrom deleted the sync-kurbo-and-image branch January 30, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance cleans up code or docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants