Add type_name to panic error messages in WidgetPod#2380
Merged
xStrom merged 6 commits intolinebender:masterfrom May 31, 2023
Merged
Conversation
Contributor
|
I haven't tested this, but this looks valuable to me. |
jneem
approved these changes
May 29, 2023
matthewgapp
force-pushed
the
matt/improve/better-widgetpod-panic-error-messages
branch
from
caa6184 to
8ff9774
Compare
Contributor
Author
thanks, I removed the unnecessary formatting. |
jaredoconnell
approved these changes
May 30, 2023
xStrom
reviewed
May 30, 2023
Co-authored-by: Kaur Kuut <strom@nevermore.ee>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, just started tinkering with Druid and think that it could work well for my current project. Even though it's "discontinued", I'd like to start contributing to soften some of the rough edges while Xilem gets off the ground.
This PR introduces a super small change, adding the typename to the panic messages. I ran into this while running down a another bug in my app. I couldn't make heads or tails about which component was causing issues because WidgetPod is used under the hood in so many places. I think adding information. about which type is experiencing the panic will be helpful to others, too.