Fix #265 PostQuitMessage when WM_DESTROY in Win#681
Closed
usagi wants to merge 1 commit intolinebender:masterfrom
Closed
Fix #265 PostQuitMessage when WM_DESTROY in Win#681usagi wants to merge 1 commit intolinebender:masterfrom
usagi wants to merge 1 commit intolinebender:masterfrom
Conversation
raphlinus
reviewed
Mar 17, 2020
Contributor
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
This will quit when any window is closed, even if there are more than one open. A more subtle approach is needed, but thanks for trying to fix it.
Author
|
Thanks for your review. Okay, I close it just now. |
Member
|
The correct fix is linked in one of the other issues I think? or grep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to exit the loop normally when the window is closed in Windows.
Related: #265 ( and #674, #438, #395, #362 )