Rendering tests by fishrockz · Pull Request #784 · linebender/druid

fishrockz · 2020-03-30T21:55:13Z

The last few commits need cleaning up but I am generally keen to get some good feed back before I clean them up.

This PR adds:

Ability to get a array of raw pixels and so they can be checked
Ability to save a png of the widget under test
Image tests
Svg tests that test that the scaling matrix and transform matrix work together

This PR should complete #527

druid/src/tests/mod.rs

druid-shell/Cargo.toml

cmyr

Okay I think all things considered this is a reasonable way to get the functionality we want, and we're allowed to be more hacky with testing code.

That said, I think it is important that future explorers of this code have some more hints about what is going on; if you can try and add some docs etc I will clean them up.

druid/src/tests/harness.rs

druid/src/tests/mod.rs

druid/src/tests/harness.rs

druid/src/tests/mod.rs

druid/src/tests/harness.rs

druid/Cargo.toml

fishrockz · 2020-04-07T21:24:57Z

druid/src/widget/image.rs

+                    vec![41, 41, 41, 255].repeat(100),
+                ]
+                .concat();
+                assert_eq!(raw_pixels[399 * 600 * 4..400 * 600 * 4], expecting[..]);


@raphlinus I think you did a lot of the piet logic, can you think of a nicer way to do this. I have made these tests so that they should be very stable but if people want to use this for more complex widgets then crafting a expected slice could get quite trouble some especially if they are not to be pretty fragile.

I was thinking of maybe using piet to create a similar image and then comparing the hole things but I'm not sure that would be very helpful.

Maybe for another MR but do you have any ideas?

druid/src/tests/harness.rs

xStrom

Mostly grammar related stuff. However I'm also wondering about the temp dir/files lifetime.

druid/src/tests/harness.rs

druid/src/widget/svg.rs

xStrom

Just a few more.

druid/src/tests/mod.rs

xStrom

Okay I think this is at a decent enough place now to merge. Thanks!

cmyr

Thanks!

fishrockz commented Mar 30, 2020

View reviewed changes

druid/src/tests/mod.rs Show resolved Hide resolved

xStrom reviewed Mar 30, 2020

View reviewed changes

druid-shell/Cargo.toml Outdated Show resolved Hide resolved

fishrockz added the S-needs-review waits for review label Mar 31, 2020

fishrockz force-pushed the willsalmon/imagetests branch 2 times, most recently from 16438e7 to 2140c1b Compare March 31, 2020 20:55

fishrockz changed the title ~~WIP: Rendering tests~~ Rendering tests Mar 31, 2020

cmyr reviewed Apr 3, 2020

View reviewed changes

druid/src/tests/harness.rs Outdated Show resolved Hide resolved

druid/src/tests/mod.rs Outdated Show resolved Hide resolved

druid/src/tests/harness.rs Outdated Show resolved Hide resolved

druid/src/tests/mod.rs Show resolved Hide resolved

cmyr added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels Apr 3, 2020

fishrockz force-pushed the willsalmon/imagetests branch 2 times, most recently from 2fdb202 to 4a3642e Compare April 6, 2020 19:16

fishrockz commented Apr 7, 2020

View reviewed changes

druid/src/tests/harness.rs Outdated Show resolved Hide resolved

fishrockz force-pushed the willsalmon/imagetests branch 2 times, most recently from a3805bc to 49835b0 Compare April 7, 2020 21:09

fishrockz commented Apr 7, 2020

View reviewed changes

druid/Cargo.toml Outdated Show resolved Hide resolved

fishrockz commented Apr 7, 2020

View reviewed changes

fishrockz force-pushed the willsalmon/imagetests branch 3 times, most recently from 961b3b9 to 94ee520 Compare April 7, 2020 22:10

xStrom mentioned this pull request Apr 8, 2020

Add test to make sure into_raw_pixels doesn't crash. linebender/piet#160

Closed

fishrockz force-pushed the willsalmon/imagetests branch 2 times, most recently from bb3d301 to 8454c76 Compare April 8, 2020 18:12

xStrom reviewed Apr 9, 2020

View reviewed changes

druid/src/tests/harness.rs Show resolved Hide resolved

fishrockz force-pushed the willsalmon/imagetests branch from 8454c76 to d6e59d9 Compare April 10, 2020 11:39

fishrockz added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels Apr 10, 2020

xStrom requested changes Apr 10, 2020

View reviewed changes

xStrom added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels Apr 10, 2020

fishrockz force-pushed the willsalmon/imagetests branch from d6e59d9 to f47e398 Compare April 10, 2020 21:33

fishrockz force-pushed the willsalmon/imagetests branch 2 times, most recently from 8454296 to 04c229e Compare April 10, 2020 21:53

fishrockz added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels Apr 10, 2020

xStrom reviewed Apr 10, 2020

View reviewed changes

druid/src/tests/mod.rs Outdated Show resolved Hide resolved

fishrockz force-pushed the willsalmon/imagetests branch 2 times, most recently from dd32ed0 to 4bdc3fe Compare April 14, 2020 18:09

xStrom approved these changes Apr 15, 2020

View reviewed changes

fishrockz force-pushed the willsalmon/imagetests branch from 4bdc3fe to 2996ae2 Compare April 15, 2020 21:45

Add function for creating temporary files

fec0623

fishrockz force-pushed the willsalmon/imagetests branch from 2996ae2 to 5eb90b9 Compare April 16, 2020 21:27

fishrockz added 4 commits April 16, 2020 22:29

Add dependencies

236abd3

Add second call back so test can inspect what was painted

15898a2

Add some render tests for image

1722e89

Add basic svg transform tests

1ad10a2

fishrockz force-pushed the willsalmon/imagetests branch from 5eb90b9 to 1ad10a2 Compare April 16, 2020 21:30

cmyr approved these changes Apr 17, 2020

View reviewed changes

cmyr merged commit 22cd067 into linebender:master Apr 17, 2020

xStrom removed the S-needs-review waits for review label May 15, 2020

totsteps mentioned this pull request May 22, 2020

Add ability to save a render of a widget to file during tests #527

Closed

Conversation

fishrockz commented Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmyr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fishrockz Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xStrom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xStrom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xStrom left a comment

Choose a reason for hiding this comment

Uh oh!

cmyr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fishrockz commented Mar 30, 2020 •

edited

Loading