Actually close GTK windows#797
Merged
cmyr merged 1 commit intolinebender:masterfrom Apr 3, 2020
luleyleo:gtk-close-window
Merged
Actually close GTK windows#797cmyr merged 1 commit intolinebender:masterfrom luleyleo:gtk-close-window
cmyr merged 1 commit intolinebender:masterfrom
luleyleo:gtk-close-window
Conversation
Collaborator
|
I'm currently testing this in relation to #464 but I do have a question in the meantime. What specifically about the |
Collaborator
Author
|
@ForLoveOfCats The close item in the file menu did not work (as it works exactly like a custom close button) |
ForLoveOfCats
approved these changes
Apr 3, 2020
Member
|
Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of removing the window from the application, it now gets closed.
This Closes #464 and also fixes the
multiwinexample with GTK.Closing a window will also remove it from the
Application