Skip to content

Replace #[macro_use] with normal use#808

Merged
cmyr merged 4 commits intolinebender:masterfrom
totsteps:replace_macro_use
Apr 8, 2020
Merged

Replace #[macro_use] with normal use#808
cmyr merged 4 commits intolinebender:masterfrom
totsteps:replace_macro_use

Conversation

@totsteps
Copy link
Collaborator

@totsteps totsteps commented Apr 7, 2020

closes #805

@totsteps totsteps requested a review from luleyleo April 7, 2020 01:47
@totsteps totsteps added the S-needs-review waits for review label Apr 7, 2020
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks 👍
@cmyr I think we can get this merged

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit, but otherwise looks good, thanks!

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this sort of little cleanup is always appreciated.

use super::keycodes::KeyCode;
use std::fmt;

use super::keycodes::KeyCode;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 😄

@cmyr cmyr merged commit d4cb921 into linebender:master Apr 8, 2020
@totsteps totsteps deleted the replace_macro_use branch April 8, 2020 07:10
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace #[macro_use] with normal use

4 participants