Conversation
This is a fairly simple widget that displays a label that can be edited on click. The input is validated, and the data is only mutated when editing completes.
Collaborator
|
I'm probably being dense but in which ways does this differ from a |
Member
Author
|
it looks like a label when it isn't being edited; it has a non |
This was referenced Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fairly simple widget that displays a label that can be edited on click. The input is validated, and the data is only mutated when editing completes.
This is something I need in runebender. I don't want to merge this in its current state, but wanted to see what people think; it illustrates some of how I've been thinking about validation in general.
I'm not opposed to merging something like this, as a temporary measure, but I would want to at least remove the changes to the
helloexample.