Add proper CI testing coverage and optimize it for speed.#857
Merged
xStrom merged 2 commits intolinebender:masterfrom Apr 17, 2020
Merged
Add proper CI testing coverage and optimize it for speed.#857xStrom merged 2 commits intolinebender:masterfrom
xStrom merged 2 commits intolinebender:masterfrom
Conversation
Member
|
Wonderful, the problem with this stuff is definitely maintenance; it seems to consistently degrade over any serious set of changes. Hopefully we don't have too many additional targets coming in the near future, though? 😬 |
cmyr
approved these changes
Apr 17, 2020
Member
cmyr
left a comment
There was a problem hiding this comment.
Looks good on a skim. Thanks for taking this on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent some time really reading through the cargo docs and inspecting our workspace structure. This PR is the result of that. It covers more code and is faster.
cargo rustcsteps ascargo clippyalready compiles the code and fails on the same warnings. I verified this and it's stated in the clippy readme: