Make window title LabelText instead of LocalizedString#869
Merged
Conversation
It isn't really possible for code outside of druid to use LocalizedString in any reasonable way at the moment, and so this makes it much easier to set a window title, especially a title that is generated dynamically from the data.
cmyr
added a commit
to linebender/runebender
that referenced
this pull request
Apr 23, 2020
This will now update when the glyph name changes. This depends on linebender/druid#869
luleyleo
approved these changes
Apr 23, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
The need for LocalizedString always annoyed me when I just wanted to set a static title 😅
I think this makes more sens.
cmyr
added a commit
to linebender/runebender
that referenced
this pull request
Apr 23, 2020
This will now update when the glyph name changes. This depends on linebender/druid#869
cmyr
added a commit
to linebender/runebender
that referenced
this pull request
Apr 23, 2020
This will now update when the glyph name changes. This depends on linebender/druid#869
cmyr
added a commit
to linebender/runebender
that referenced
this pull request
Apr 23, 2020
This will now update when the glyph name changes. This depends on linebender/druid#869
Collaborator
|
Thanks! This is a great change. I always needed to copy-paste setting window title from another example before. |
Member
Author
|
yes, sorry for making it wait so long 😅 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It isn't really possible for code outside of druid to use
LocalizedString in any reasonable way at the moment, and so
this makes it much easier to set a window title, especially
a title that is generated dynamically from the data.