Fix incorrect LifeCycleCtx with FocusChanged event#878
Merged
Conversation
xStrom
requested changes
Apr 24, 2020
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
This is definitely an improvement. I've ran into these wrong context cases myself but was holding off with the fix due to thinking of doing a through test function first.
The propagation logic shouldn't be changed though.
druid/src/core.rs
Outdated
Comment on lines
+648
to
+650
| substitute_event = Some(LifeCycle::FocusChanged(change)); | ||
| } | ||
| false | ||
| true |
Member
There was a problem hiding this comment.
The true should be inside the if old != new block and false otherwise. An else block with false would work.
We were handling this event separately, and were accidentally reusing the parent context, instead of the child context; this has the concrete problem that the context had an incorrect WidgetId. This fix feels like the lesser of two evils; we add a mechanism for explicitly substituting a new event for the one received, ensuring that we only call the child's lifecycle method in one place.
cmyr
force-pushed
the
focus-changed-fixup
branch
from
3812379 to
21d46bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were handling this event separately, and were accidentally
reusing the parent context, instead of the child context;
this has the concrete problem that the context had
an incorrect WidgetId.
This fix feels like the lesser of two evils; we add a mechanism
for explicitly substituting a new event for the one received,
ensuring that we only call the child's lifecycle method in one place.
(this explains what I was doing with #876 😅)