Skip to content

Refactor GTK Application to make use of the new structure.#892

Merged
xStrom merged 3 commits intolinebender:masterfrom
xStrom:application-linux
May 6, 2020
Merged

Refactor GTK Application to make use of the new structure.#892
xStrom merged 3 commits intolinebender:masterfrom
xStrom:application-linux

Conversation

@xStrom
Copy link
Member

@xStrom xStrom commented Apr 30, 2020

#763 introduced a new instance based Application structure. This PR refactors the GTK Application code to make use of it, as well as adding better error reporting and removing duplicate thread assertions.

@xStrom xStrom added S-needs-review waits for review shell/gtk concerns the GTK backend labels Apr 30, 2020
@xStrom xStrom force-pushed the application-linux branch from a43d1f1 to faead0c Compare April 30, 2020 18:43
@xStrom xStrom force-pushed the application-linux branch from faead0c to d41c27c Compare May 2, 2020 14:53
Copy link
Collaborator

@luleyleo luleyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xStrom xStrom merged commit e2b4804 into linebender:master May 6, 2020
@xStrom xStrom deleted the application-linux branch May 6, 2020 11:26
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell/gtk concerns the GTK backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants