Refactor X11 Application to make use of the new structure.#894
Refactor X11 Application to make use of the new structure.#894xStrom merged 13 commits intolinebender:masterfrom
Conversation
|
I also refactored Partial invalidation is also really broken on There's still an issue that the still-valid areas get cleared during partial repaint. I'll see if I can fix it quickly, but otherwise I think that would be fine for a new PR too. |
|
I ended up fixing partial invalidation too. 🎉 |
luleyleo
left a comment
There was a problem hiding this comment.
The X11 backend works A LOT better with this, thanks!
The inline comments aside I've found two issues:
- Closing one window in the
multiwinexample closes all windows - Somtimes widgets disappear, for example hovering over a button in the list example makes the label next to it disappear, or in
game_of_lifethe slider / buttons at the bottom vanish when hovering another one.
|
I added more logging and cleanup of The |
luleyleo
left a comment
There was a problem hiding this comment.
Looks all good now, thanks 👍
#763 introduced a new instance based
Applicationstructure. This PR refactors the X11Applicationcode to make use of it, as well as adding better error reporting.The
windowsmap has reentrancy issues. Those were already there and this PR makes no attempt at solving them. I just merely refactored it to the newApplicationstyle.