Optimize clippy trivially_copy_pass_by_ref for 64-bit.#909
Merged
xStrom merged 1 commit intolinebender:masterfrom May 9, 2020
Merged
Optimize clippy trivially_copy_pass_by_ref for 64-bit.#909xStrom merged 1 commit intolinebender:masterfrom
xStrom merged 1 commit intolinebender:masterfrom
Conversation
xStrom
added
maintenance
luleyleo
approved these changes
May 9, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
Thanks a lot for your help in figuring this out 😄
And I have a language question again.
| @@ -0,0 +1,5 @@ | |||
| # The default clippy value for this is 8 bytes, which is chosen to improve performance on 32-bit. | |||
| # Given that druid is being designed for the future and already even mobile phones have 64-bit CPUs, | |||
Collaborator
There was a problem hiding this comment.
and already even mobile phones have 64-bit CPUs
Is it correct to place already there?
and even mobile phones already have 64-bit CPUs
feels better to me.
Member
Author
There was a problem hiding this comment.
Both are fine and you could even put it at the end. Check out this Cambridge dictionary page about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
trivially_copy_pass_by_refto 16 bytes, which is the number of bytes that fit into two 64-bit CPU registers.The default clippy value for this is 8 bytes, which is chosen to improve performance on 32-bit. Given that druid is being designed for the future and already even mobile phones have 64-bit CPUs, it makes sense to optimize for 64-bit and accept the performance hits on 32-bit.
This also changes command
Targetto be passed by value. It's a breaking change, but given that commands are getting redone in #908 anyway, I think this is about as perfect of a time to change this as possible.