Move HWND render target creation to WM_CREATE.#916
Merged
xStrom merged 1 commit intolinebender:masterfrom May 22, 2020
Merged
Conversation
xStrom
added
shell/win
Member
|
I don't have access to a windows machine right now, so I can't test this. :( |
raphlinus
approved these changes
May 22, 2020
Contributor
raphlinus
left a comment
raphlinus
left a comment
There was a problem hiding this comment.
This also seems reasonable to me. I didn't do careful measurement, but the flash on startup does appear to be shorter on my Windows 7 test machine, and I also didn't find anything that breaks. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should help with the initial white flash reported in #914. On my Windows 7 desktop I measured the HWND render target creation at 39ms. This is definitely too long to lazily create in
WM_PAINTso I moved it toWM_CREATE.Even if it doesn't fully fix the white flash, it cuts down the first frame time by 39ms on my machine, so it's worth a merge regardless.
I left the check in
WM_PAINTintact, because there are failure paths with dcomp that may need it.