Skip to content

Handle keyboard and button state in X11 events.#920

Merged
xStrom merged 2 commits intolinebender:masterfrom
jneem:x11-state
May 12, 2020
Merged

Handle keyboard and button state in X11 events.#920
xStrom merged 2 commits intolinebender:masterfrom
jneem:x11-state

Conversation

@jneem
Copy link
Member

@jneem jneem commented May 11, 2020

Fixes #893.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

The helper methods mouse_button / mouse_buttons / key_mods don't really need to be methods though, they don't use self. Let's make them associated functions for example by removing the &self paramater and then calling them as Window::mouse_buttons(....). Alternatively can just move them into the module scope, e.g. to the bottom of the file.

@xStrom xStrom added S-waiting-on-author waits for changes from the submitter shell/x11 concerns the X11 backend labels May 11, 2020
@jneem
Copy link
Member Author

jneem commented May 11, 2020

Thanks for the review! I've moved the functions in question to the module scope.

@xStrom
Copy link
Member

xStrom commented May 11, 2020

Yeah that looks better. Need a rebase with master and then this will be ready for merge.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xStrom xStrom merged commit 8ea0279 into linebender:master May 12, 2020
@xStrom xStrom removed the S-waiting-on-author waits for changes from the submitter label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell/x11 concerns the X11 backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X11: Add support for held down mouse buttons

2 participants