Skip to content

Update CLOSE and SHOW _WINDOW commands to utilize Target.#928

Merged
luleyleo merged 2 commits intolinebender:masterfrom
luleyleo:update-close-and-show
May 15, 2020
Merged

Update CLOSE and SHOW _WINDOW commands to utilize Target.#928
luleyleo merged 2 commits intolinebender:masterfrom
luleyleo:update-close-and-show

Conversation

@luleyleo
Copy link
Collaborator

@luleyleo luleyleo commented May 14, 2020

This is the first part of my PR for typed selectors (#908).

Now the CLOSE_WINDOW and SHOW_WINDOW commands both use the Target instead of passing the WindowId as payload.

@luleyleo luleyleo added the S-needs-review waits for review label May 14, 2020
xStrom
xStrom approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@luleyleo luleyleo added the breaking change pull request breaks user code label May 15, 2020
@luleyleo luleyleo merged commit 1f56a17 into linebender:master May 15, 2020
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xStrom xStrom xStrom approved these changes

Assignees

No one assigned

Labels

breaking change pull request breaks user code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luleyleo @xStrom