Clean up cargo manifests and generate more docs.#942
Clean up cargo manifests and generate more docs.#942xStrom merged 2 commits intolinebender:masterfrom
Conversation
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
"Code" wise it looks good. I'm wondering about the new doc CI.
Does it have to do a full doc build for each crate or can it utilize the builds of the previous crates?
Because locally it can actually reuse them and thus they would not cause any speed hit,
in which case I would not care at all about the book docs build.
| [badges] | ||
| travis-ci = { repository = "xi-editor/druid" } |
There was a problem hiding this comment.
I suppose this was removed intentionally? I could not find this badge anywhere on crates.io or docs.rs 🤔
There was a problem hiding this comment.
Yeah that's a remnant of a time when druid still used Travis CI.
| - name: cargo doc book examples | ||
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: doc | ||
| args: --manifest-path=docs/book_examples/Cargo.toml --document-private-items |
There was a problem hiding this comment.
Seems consequent, but I'm not sure we need this one?
There was a problem hiding this comment.
Well might as well make sure that the doc format in the book examples is functional.
|
The book docs build takes around 20s on the CI, which you can see from the logs. I don't think it's an issue. |
2 participants
This PR does the following:
imfeature for docs.rs/druid.The
svgandimagefeatures run into cargo bugs unfortunately and will have to wait.Cargo.tomlfiles so that they follow a unified style.