Fix progress bar rendering#949
Merged
scholtzan merged 3 commits intolinebender:masterfrom May 19, 2020
Merged
Conversation
scholtzan
commented
May 16, 2020
|
|
||
| let rounded_rect = Rect::from_origin_size( | ||
| Point::ORIGIN, | ||
| Point::new(-inset, 0.), |
Collaborator
Author
There was a problem hiding this comment.
We need to translate the rect to respect the x inset.
Member
|
Thanks for the fix! Please also add an entry to |
Collaborator
Author
|
Added an entry to the changelog |
xStrom
approved these changes
May 17, 2020
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Thanks, this works!
PS. I added the missing link in the changelog. We're hoping to automate the changelog links soon.
scholtzan
added a commit
to scholtzan/druid
that referenced
this pull request
May 17, 2020
scholtzan
force-pushed
the
fix-progressbar-rendering
branch
from
155783c to
cb66b25
Compare
Member
|
Thanks @scholtzan! |
scholtzan
force-pushed
the
fix-progressbar-rendering
branch
from
cb66b25 to
d927389
Compare
scholtzan
added a commit
that referenced
this pull request
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #919
The problem causing this rendering issue is that insets get applied to a
Rectwith zero width. This results in aRectof some negative width getting displayed when the progress bar is at zero.