Add the request_timer method to LifeCycleCtx.#954
Merged
xStrom merged 2 commits intolinebender:masterfrom May 17, 2020
Merged
Conversation
luleyleo
approved these changes
May 17, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
Interesting that it already had request_anim_frame but not request_timer 🤔
Seems like a great addition!
cmyr
approved these changes
May 17, 2020
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
One question but looks good modulo the CI issue.
| self.do_anim_frame(queue, data, env) | ||
| } else { | ||
| let mut base_state = BaseState::new(self.root.id()); | ||
| let mut ctx = LifeCycleCtx { |
Member
There was a problem hiding this comment.
hmm, I think I'm missing the reason we can't reuse the context here?
Member
Author
There was a problem hiding this comment.
It's the borrow checker. LifeCycleCtx holds an immutable reference to self while do_anim_frame wants a mutable reference to self.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
request_timermethod toLifeCycleCtxwhich will allow to fix theScrollwidget as explained in #834.To achieve this I had to introduce the
WindowHandlepointer to bothLifeCycleCtxandLayoutCtx.