Fix GTK folder selection with filters.#957
Merged
xStrom merged 2 commits intolinebender:masterfrom Jun 6, 2020
Merged
Conversation
luleyleo
reviewed
May 17, 2020
Collaborator
There was a problem hiding this comment.
I think we should log a warning in case someone tries to do this.
Also I think it would make sens to either enforce this on all platforms, or add documentation that there is no guarantee for filters to work with folders on any platform (besides macOS)?
Member
Author
|
After looking more deeply into it, filters don't really work on directories even on macOS. They work on packages instead. I cleaned up the API and added better docs in #960. This PR now focuses on matching the newly documented API in behavior.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables file filters when opening folders, because the filter makes it impossible to traverse in the folder structure.
Fixes #947.