Add Button::dynamic constructor#963
Merged
cmyr merged 3 commits intolinebender:masterfrom May 21, 2020
totsteps:button-dynamic
Merged
Add Button::dynamic constructor#963cmyr merged 3 commits intolinebender:masterfrom totsteps:button-dynamic
cmyr merged 3 commits intolinebender:masterfrom
totsteps:button-dynamic
Conversation
totsteps
commented
May 20, 2020
luleyleo
requested changes
May 21, 2020
Collaborator
luleyleo
left a comment
luleyleo
left a comment
There was a problem hiding this comment.
Thanks for implementing this!
The changlog entry is not at the right place yet, but the rest looks good.
totsteps
added
S-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #899