Conversation
cmyr
added
S-needs-review
Merged
cmyr
force-pushed
the
base-state-to-widget-state
branch
from
7cf7b60 to
66db763
Compare
luleyleo
reviewed
May 22, 2020
CHANGELOG.md
Outdated
| - `SHOW_WINDOW` and `CLOSE_WINDOW` commands now only use `Target` to determine the affected window. ([#928] by [@finnerale]) | ||
| - Replaced `NEW_WINDOW`, `SET_MENU` and `SHOW_CONTEXT_MENU` commands with methods on `EventCtx` and `DelegateCtx`. ([#931] by [@finnerale]) | ||
| - Replaced `Command::one_shot` and `::take_object` with a `SingleUse` payload wrapper type. ([#959] by [@finnerale]) | ||
| - Renamed `BaseState` to `WidgetState` ([#969] by [@cmyr]) |
Collaborator
There was a problem hiding this comment.
BaseState / WidgetState are not public API right? In that case this is not really a change for users.
I believe it should go into the Maintenance section instead.
Member
Author
There was a problem hiding this comment.
cool, I think this should be ready to go now, pending CI.
luleyleo
added
S-waiting-on-author
cmyr
force-pushed
the
base-state-to-widget-state
branch
from
66db763 to
ddeeca5
Compare
cmyr
added
S-needs-review
This is motivated by a desire to avoid some confusion with a future patch that adds a RootState struct to unify some of the other stuff shared between various contexts.
cmyr
force-pushed
the
base-state-to-widget-state
branch
from
ddeeca5 to
5d1aa86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by a desire to avoid some confusion with a
future patch that adds a RootState struct to unify some of the
other stuff shared between various contexts.