Rename WidgetPod::paint_with_offset to just paint#980
Merged
xStrom merged 2 commits intolinebender:masterfrom May 25, 2020
totsteps:rename-paint_with_offset
Merged
Rename WidgetPod::paint_with_offset to just paint#980xStrom merged 2 commits intolinebender:masterfrom totsteps:rename-paint_with_offset
xStrom merged 2 commits intolinebender:masterfrom
totsteps:rename-paint_with_offset
Conversation
totsteps
added
breaking change
Member
|
Just came by to check if you remembered to change all the |
xStrom
reviewed
May 23, 2020
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Looks pretty good, just a few adjustments.
xStrom
added
S-waiting-on-author
totsteps
added
S-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #962