Skip to content

Fix test harness crashing on failure.#984

Merged
xStrom merged 1 commit intolinebender:masterfrom
xStrom:win-tests-fix
May 26, 2020
Merged

Fix test harness crashing on failure.#984
xStrom merged 1 commit intolinebender:masterfrom
xStrom:win-tests-fix

Conversation

@xStrom
Copy link
Member

@xStrom xStrom commented May 24, 2020

The piet context needs to be finished even if a test case fails. This PR achieves that via implementing Drop for Harness.

Fixes #950.

@xStrom xStrom added the S-needs-review waits for review label May 24, 2020
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, I'm happy. 👍

@xStrom xStrom removed the S-needs-review waits for review label May 26, 2020
@xStrom xStrom merged commit f8197e4 into linebender:master May 26, 2020
@xStrom xStrom deleted the win-tests-fix branch May 26, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double panic in test harness

2 participants