Switch to offset_{width,height} when clearing web context#158
Merged
cmyr merged 1 commit intolinebender:masterfrom Mar 27, 2020
Merged
Switch to offset_{width,height} when clearing web context#158cmyr merged 1 commit intolinebender:masterfrom
cmyr merged 1 commit intolinebender:masterfrom
Conversation
This enables proper browser zooming through the dpi/devicePixelRatio mechanism.
cmyr
approved these changes
Mar 27, 2020
Member
cmyr
left a comment
There was a problem hiding this comment.
I am going to trust you on this one 😉
Contributor
Author
|
Sorry, I should have probably elaborated more. Maybe I can motivate this change for future reference:
I think this zooming mechanism is an appropriate initial solution. However, I can imagine that it may be preferable that the rendering of some widgets is tied to screen resolution, so probably this approach will be revisited in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables proper browser zooming through the dpi/devicePixelRatio mechanism.
For reference this addresses the zooming issue in druid wasm support found in the #759.