Re-export from masonry_core, use in masonry_testing#1147
Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom Jul 11, 2025
Merged
Conversation
We have things that are deps of `masonry_core`, `masonry`, and `masonry_testing` and if you use `masonry_core`, you need to know that and use the right versions. Instead, we should be exporting these things from `masonry_core` and using them from there. This updates `masonry_testing` to use things from `masonry_core` instead and subsequent commits can further improve upon this with the `masonry` crate and so on.
waywardmonkeys
deleted the
re-export-from-masonry_core-use-in-masonry_testing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have things that are deps of
masonry_core,masonry, andmasonry_testingand if you usemasonry_core, you need to know that and use the right versions.Instead, we should be exporting these things from
masonry_coreand using them from there.This updates
masonry_testingto use things frommasonry_coreinstead and subsequent commits can further improve upon this with themasonrycrate and so on.