Fix issue with ';' delimiter when specifying multiple table keys#199
Merged
Conversation
jogrogan
force-pushed
the
jogrogan/fixMultipleKeys
branch
from
d61d836 to
15aed54
Compare
ryannedolan
approved these changes
Mar 23, 2026
ryannedolan
added a commit
that referenced
this pull request
Mar 23, 2026
Resolve conflict in venice-ddl-insert-partial.id: take main's updated SQL with multiple key fields (;-delimiter fix from #199) in SqlJob format. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
";" delimiter in key.fields was causing incorrect parsing, a line break was being inserted in the middle of the flink connector options.
Added testing to cover this case.