Skip to content

Support 3-part "CATALOG.SCHEMA.TABLE" identifier in CREATE TRIGGER#223

Merged
srnand merged 1 commit into
mainfrom
srnand/may14/AddCatalogSupportOnTableTrigger
May 15, 2026
Merged

Support 3-part "CATALOG.SCHEMA.TABLE" identifier in CREATE TRIGGER#223
srnand merged 1 commit into
mainfrom
srnand/may14/AddCatalogSupportOnTableTrigger

Conversation

@srnand
Copy link
Copy Markdown
Collaborator

@srnand srnand commented May 14, 2026

Summary

  • CREATE TRIGGER ... ON catalog.schema.table now stores the catalog on the resulting TableTrigger CRD (new optional spec.catalog field).
  • The catalog is also bound as {{catalog}} for JobTemplate rendering, alongside the existing {{schema}} and {{table}}.
  • 2-part ON schema.table is unchanged — spec.catalog simply stays unset.

Example

CREATE TRIGGER dummy_retl_trigger ON ads_catalog.ads.ad_clicks 
AS 'retl-job-template' IN 'default' 
WITH (
'offline.table.name' 'my-namespace.my-table',
'job.properties.online.table.name' 'MyOnlineTable'
);
➜  ~ k get tabletriggers dummyretltrigger -oyaml
apiVersion: hoptimator.linkedin.com/v1alpha1
kind: TableTrigger
metadata:
  ...
  name: dummyretltrigger
  namespace: default
  resourceVersion: "1851126"
  uid: 6394d2d2-8c7d-4cbc-998e-a43530ba2df4
spec:
  catalog: ADS_CATALOG
  jobProperties:
    online.table.name: MyOnlineTable
  schema: ADS
  table: AD_CLICKS
  yaml: |
    apiVersion: batch/v1
    kind: Job
    metadata:
      name: dummyretltrigger-retl-job-template-job
    spec:
      ...

CREATE TRIGGER dummy_retl_trigger ON ads.ad_clicks 
AS 'retl-job-template' IN 'default' 
WITH (
'offline.table.name' 'my-namespace.my-table',
'job.properties.online.table.name' 'MyOnlineTable'
);
➜  ~ k get tabletriggers dummyretltrigger -oyaml
apiVersion: hoptimator.linkedin.com/v1alpha1
kind: TableTrigger
metadata:
  creationTimestamp: "2026-05-14T22:36:27Z"
  generation: 1
  labels:
    view: ads-adclicks
  name: dummyretltrigger
  namespace: default
  resourceVersion: "1851103"
  uid: a97b3b4d-8718-4fb0-8283-9827777a7151
spec:
  jobProperties:
    online.table.name: MyOnlineTable
  schema: ADS
  table: AD_CLICKS
  yaml: |
    apiVersion: batch/v1
    kind: Job
    metadata:
      name: dummyretltrigger-retl-job-template-job
    spec:
      ...

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Code Coverage

Overall Project 84.42% -0.01% 🟢
Files changed 94.44% 🟢

File Coverage
K8sTableTriggerTable.java 100% 🟢
K8sTriggerDeployer.java 92.16% -0.48% 🟢

@srnand srnand requested a review from ryannedolan May 14, 2026 23:43
Copy link
Copy Markdown
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@srnand srnand merged commit 1ff22cd into main May 15, 2026
1 check passed
@srnand srnand deleted the srnand/may14/AddCatalogSupportOnTableTrigger branch May 15, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants