Infer path variable from ON-clause path#224
Open
srnand wants to merge 3 commits into
Open
Conversation
ryannedolan
reviewed
May 15, 2026
Collaborator
ryannedolan
left a comment
ryannedolan
left a comment
There was a problem hiding this comment.
Nice! Couple comments.
Base automatically changed from
srnand/may14/AddCatalogSupportOnTableTrigger
to
main
May 15, 2026 05:30
Replaced `{{offline.table.name}}` in JobTemplates with `{{path}}` which now defaults to
`source.pathString()` (the fully-qualified `CATALOG.SCHEMA.TABLE` /
`SCHEMA.TABLE` from the trigger's ON clause), so users no longer need to
repeat the path in `WITH ('offline.table.name' '...')`. An explicit
option still wins because `.with(properties)` merges on top of the
default binding.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
srnand
force-pushed
the
srnand/may14/DeriveOfflineTableNameFromOnClause
branch
from
55459ba to
41b250d
Compare
Code Coverage
|
srnand
force-pushed
the
srnand/may14/DeriveOfflineTableNameFromOnClause
branch
from
41b250d to
f90ad54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{offline.table.name}}in JobTemplates with{{path}}which now defaults tosource.pathString()(the fully-qualifiedCATALOG.SCHEMA.TABLE/SCHEMA.TABLEfrom the trigger's ON clause), so users no longer need to repeat the path inWITH ('offline.table.name' '...').