upload-fsimage.sh should check whether VERSION exists before uploading?

[sunchao]

upload-fsimage.sh failed at the end because VERSION file already exists in the target HDFS dir:

sunchao@HOSTNAME:~/dynamometer$ bin/upload-fsimage.sh XXX hdfs:///app/dyno/fsimage /home/sunchao/fsimage
Using fsimage: fsimage_XXX
Creating temporary XML fsimage file at /tmp/tmp.IUfFlwXXdk/fsimage_XXX.xml
Created temporary XML fsimage file
Uploading /home/sunchao/fsimage/current/fsimage_XXX...
Uploading /tmp/tmp.IUfFlwXXdk/fsimage_XXX.xml...
Uploading /home/sunchao/fsimage/current/fsimage_XXX.md5...
Uploading /home/sunchao/fsimage/current/VERSION...
copyFromLocal: `hdfs:///app/dyno/fsimage/VERSION': File exists
Error while uploading /home/sunchao/fsimage/current/VERSION; exiting

Perhaps we can check if VERSION exists before converting to XML? or maybe skip the check if it already exists? this is only a minor issue though as the fsimage file is already uploaded.

[xkrogen]

Probably we can just do a -copyFromLocal -f to force overwrite instead of failing on file existence?

[sunchao]

Yes, it should just be as simple as that :) I don't think overwriting it will have any risk.