Skip to content

Closes #25. Set up Travis CI and add in a Gradle wrapper.#26

Merged
xkrogen merged 1 commit into
linkedin:masterfrom
xkrogen:ekrogen-travis-ci-setup
Apr 10, 2018
Merged

Closes #25. Set up Travis CI and add in a Gradle wrapper.#26
xkrogen merged 1 commit into
linkedin:masterfrom
xkrogen:ekrogen-travis-ci-setup

Conversation

@xkrogen

@xkrogen xkrogen commented Apr 6, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@xkrogen

xkrogen commented Apr 6, 2018

Copy link
Copy Markdown
Collaborator Author

CI build failed due to test failure fixed in PR #18. Hadoop 2.9 build failed because the proper fsimage files are not set up; I will update. But it looks that overall the Travis integration is working as expected. Very cool! And it builds all of the Hadoop versions in parallel. Great stuff.

@oliverhu

oliverhu commented Apr 6, 2018

Copy link
Copy Markdown

have you considered using CircleCI? We have free trial for OSS. The Travis queue is pretty congested.

Comment thread .travis.yml
jdk:
- oraclejdk8
env:
- HADOOP_VERSION=2.7.5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will these run in parallel or one by one ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parallel

@xkrogen

xkrogen commented Apr 6, 2018

Copy link
Copy Markdown
Collaborator Author

@oliverhu Is there any benefit to using CircleCI over TravisCI? I know of other LinkedIn projects (Azkaban) using TravisCI, and the integration was exceedingly easy. They also have a committed to be always free for OSS. Does CircleCI have something similar?

re: your congestion comment, I don't know if I just got lucky, but all of my tests started in only a few seconds after pushing.

@oliverhu

oliverhu commented Apr 6, 2018

Copy link
Copy Markdown

@xkrogen Functionality wise, as far as the functionalities I need, there is no much difference. The major benefit is the queue is much more empty in CircleCI comparing with Travis CI. IIRC, we use free tier for both TravisCI & CircleCI, but 99% of the projects are using TravisCI sharing the same queue. It used to take us 3 hours before any resource is available to check our PRs..

@xkrogen

xkrogen commented Apr 6, 2018

Copy link
Copy Markdown
Collaborator Author

Looks like in the free tier on CircleCI we cannot take advantage of any parallel execution because only a single container is granted, is that right?

This is from CircleCI's website:

While Travis CI is focused on the open source market, CircleCI focuses on performance and service designed to solve the needs of professional engineering organizations looking to scale.

Based on this this sentence alone, it seems to me that TravisCI is a better fit.

Maybe if we see issues with build time then CircleCI can be further investigated.

@oliverhu

Copy link
Copy Markdown

Not sure, we only used single execution for macOS containers and the performance was really good. Yeah, just want to point out there are other available CI solutions available.

@xkrogen

xkrogen commented Apr 10, 2018

Copy link
Copy Markdown
Collaborator Author

Thanks for the info @oliverhu ! I suspect that the TravisCI queue with Linux containers instead of macOS may perform better. If we do see issues I'll definitely look into CircleCI.

@xkrogen xkrogen merged commit d137b93 into linkedin:master Apr 10, 2018
@xkrogen xkrogen deleted the ekrogen-travis-ci-setup branch April 10, 2018 17:30
@xkrogen

xkrogen commented Apr 10, 2018

Copy link
Copy Markdown
Collaborator Author

Also, if their status page is to be trusted, at no point in the last month has there ever been a backlog of Linux open source jobs: https://www.traviscistatus.com/#month

xkrogen added a commit to xkrogen/dynamometer that referenced this pull request Apr 10, 2018
… proper test files for 2.9.0, and add a travis_wait step to avoid timeouts.

Add in 2.6.5 to CI testing

Add in proper 2.9 test files

travis_wait
xkrogen added a commit to xkrogen/dynamometer that referenced this pull request Apr 10, 2018
… proper test files for 2.9.0, and add a travis_wait step to avoid timeouts.
xkrogen added a commit that referenced this pull request Apr 10, 2018
…p 2.6 build, increase logging for debuggability, and add a status badge. (PR #27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants