Clean up MiniYARNCluster setup to not use fixed ports#74
Merged
Conversation
chliang71
approved these changes
Jan 11, 2019
chliang71
left a comment
chliang71
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with one minor comment
…asspath setup as in TestDistributedShell
xkrogen
force-pushed
the
ekrogen-no-fixed-yarn-ports
branch
from
13b1fcd to
22e847a
Compare
Collaborator
|
LGTM, +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing tests relied on a MiniYARNCluster that used fixed ports for the YarnClient to know how to communicate with it. Following the example of
TestDistributedShell, it's possible to do this without fixed ports, which helps the test to be more robust.