Add Shipkit integration for Bintray deployment#79
Conversation
xkrogen
left a comment
There was a problem hiding this comment.
Based on https://github.com/mockito/shipkit/blob/master/docs/getting-started.md#initializing-shipkit , it sounds like there should be a version.properties file?
Let's make sure we do a test run as described here: https://github.com/mockito/shipkit/blob/master/docs/getting-started.md#test-run
|
Fixed up: can't do a test yet without the requisite Github and Bintray keys. |
|
Have we tried uploading to the shipkit-bootstrap repo for testing as described in the ShipKit getting started docs? https://github.com/mockito/shipkit/blob/master/docs/getting-started.md#test-run |
xkrogen
left a comment
There was a problem hiding this comment.
I set up the TravisCI repo settings to have the necessary keys. But please let's do a test push as described in the ShipKit setup before committing this.
|
Only took 17 tries: https://github.com/csgregorian/dynamometer/releases/tag/v0.1.17 |
|
Cool! Is there anything I should be aware of to prevent it from taking 17 tries on the real repository? 😄 I took a look through the files that got added: https://bintray.com/version/files/shipkit-bootstrap/bootstrap/maven/0.1.17?order=asc&sort=name&basePath=com%2Flinkedin%2Fdynamometer&tab=files |
|
tl;dr things that (probably) won't make a difference in CI
|
xkrogen
left a comment
There was a problem hiding this comment.
LGTM. Let's see how it goes!
Shipkit setup for Bintray deployment, requires env vars and probably some other config changes.