Add travis build step and fix javadoc formatting#80
Merged
Conversation
xkrogen
reviewed
Feb 26, 2019
xkrogen
reviewed
Feb 26, 2019
xkrogen
approved these changes
Feb 26, 2019
xkrogen
left a comment
xkrogen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM besides minor suggested changes
csgregorian
force-pushed
the
build-step-and-javadoc
branch
6 times, most recently
from
5322773 to
931bb41
Compare
csgregorian
force-pushed
the
build-step-and-javadoc
branch
3 times, most recently
from
7be697a to
1cad33c
Compare
csgregorian
force-pushed
the
build-step-and-javadoc
branch
from
1cad33c to
a94aff6
Compare
Contributor
Author
|
Fixed changes and modified the build script a bit further: it runs a single build job (which doesn't depend on the |
xkrogen
approved these changes
Feb 27, 2019
xkrogen
left a comment
xkrogen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @csgregorian !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the javadoc formatting that gradle was complaining about and added a travis step that should build the whole thing every time.