Skip to content

Bumped Gradle and removed the workaround#87

Merged
xkrogen merged 1 commit into
linkedin:masterfrom
mockitoguy:master
Mar 1, 2019
Merged

Bumped Gradle and removed the workaround#87
xkrogen merged 1 commit into
linkedin:masterfrom
mockitoguy:master

Conversation

@mockitoguy

Copy link
Copy Markdown
Contributor

I bumped to latest 4.x version and it resolves the problem. I put back the original Shipkit settings.

I bumped to latest 4.x version and it resolves the problem. I put back the original Shipkit settings.

@xkrogen xkrogen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should have been using the latest and greatest Gradle the whole time I guess.

@xkrogen xkrogen merged commit 8f7efac into linkedin:master Mar 1, 2019
@mockitoguy

Copy link
Copy Markdown
Contributor Author

No worries!

xkrogen added a commit that referenced this pull request Mar 4, 2019
@xkrogen

xkrogen commented Mar 4, 2019

Copy link
Copy Markdown
Collaborator

I had to revert this as it was causing the build to completely be unable to read any property specified within the bintray closure:

[performRelease] > Task :dynamometer-blockgen:bintrayUpload
[performRelease] :dynamometer-blockgen:bintrayUpload - publishing to Bintray
[performRelease]   - dry run: false, publish: true, version: 0.1.2, Maven Central sync: true
[performRelease]   - user/org: null/null, repository/package: null/com.linkedin.dynamometer
[performRelease] Repository name, package name or version name are null for project: project ':dynamometer-blockgen'
[performRelease]

(all of the specified properties are getting read as null)

Build link here: https://travis-ci.org/linkedin/dynamometer/jobs/500652004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants