Make XML parsing error message more explicit#97
Merged
Conversation
Collaborator
|
@fengnanli , can you look into the test failure? It looks legitimate. |
Contributor
Author
|
@xkrogen so the parsing failed at this line: FYI, hdfs oiv 2.8.2 doesn't generate |
This should be revisited in the future
Collaborator
|
Interesting... Thanks for the info! I would definitely welcome a change which supports the new-style |
xkrogen
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two points in this pr:
when parsing the xml INodeSection, the state machine actually requires that must be the ending of a line, otherwise other states will kick in thus will result in errors.
expose the actual line under parsing in the exceptions for easier debugging, otherwise there is no clue what happened.